[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [Qemu-devel] [PATCH 06/13] qcrypto-luks: implement more
|
From: |
Maxim Levitsky |
|
Subject: |
Re: [Qemu-block] [Qemu-devel] [PATCH 06/13] qcrypto-luks: implement more rigorous header checking |
|
Date: |
Mon, 26 Aug 2019 16:39:18 +0300 |
On Mon, 2019-08-26 at 08:31 -0500, Eric Blake wrote:
> On 8/25/19 11:08 AM, Maxim Levitsky wrote:
>
> > > > I'd do a separate check for stripes and active fields, and then give a
> > > > specific error message for each. That way if this does ever trigger
> > > > in practice will immediately understand which check failed.
> > > >
> > > > Also using '%d' rather than '%i' is more common convention
> > >
> > > Done.
> >
> > Note that I switched i,j to be size_t since you said that you prefer this,
> > and to print this I apparently need %lu.
>
> Actually, for size_t, you need %zu. %lu/size_t will cause warnings on
> 32-bit platforms.
>
>
Thank you!
I have read something like that on the internet, but I wondered,
what actually is the most portable way.
Best regards,
Maxim Levitsky
- Re: [Qemu-block] [PATCH 07/13] block: add manage-encryption command (qmp and blockdev), (continued)
[Qemu-block] [PATCH 06/13] qcrypto-luks: implement more rigorous header checking, Maxim Levitsky, 2019/08/14
[Qemu-block] [PATCH 08/13] qcrypto: add the plumbing for encryption management, Maxim Levitsky, 2019/08/14
[Qemu-block] [PATCH 09/13] qcrypto-luks: implement the encryption key management, Maxim Levitsky, 2019/08/14
[Qemu-block] [PATCH 10/13] block/crypto: implement the encryption key management, Maxim Levitsky, 2019/08/14