[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-block] [PATCH v3 3/7] block/io: handle alignment and max_trans

From: Vladimir Sementsov-Ogievskiy
Subject: Re: [Qemu-block] [PATCH v3 3/7] block/io: handle alignment and max_transfer for copy_range
Date: Tue, 20 Aug 2019 15:18:28 +0000

12.08.2019 17:48, Max Reitz wrote:
> On 10.08.19 21:31, Vladimir Sementsov-Ogievskiy wrote:
>> copy_range ignores these limitations, let's improve it.
>> Signed-off-by: Vladimir Sementsov-Ogievskiy <address@hidden>
>> ---
>>   block/io.c | 44 ++++++++++++++++++++++++++++++++++++--------
>>   1 file changed, 36 insertions(+), 8 deletions(-)
> Reviewed-by: Max Reitz <address@hidden>

Hmm. Now I think that next patch is arguable, and I still don't see true way of
organizing limitation of request length and memory allocation in conjunction 
async requests in backup.

So, I'll send next version of "improvements" without this (there are already 
simpler patches).

And this patch becomes something separate. Do you think we need it anyway? If 
please queue it in separate. It may be better to return ENOTSUP on too big 
too, to keep simpler code and make callers optimize their copying loops by 

Best regards,

reply via email to

[Prev in Thread] Current Thread [Next in Thread]