[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-block] [PATCH 3/6] tests/libqtest: Remove unused function hmp(

From: Eric Blake
Subject: Re: [Qemu-block] [PATCH 3/6] tests/libqtest: Remove unused function hmp()
Date: Tue, 13 Aug 2019 10:20:14 -0500
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.0

On 8/13/19 4:30 AM, Thomas Huth wrote:
> No test is using hmp() anymore, and since this function uses the disliked
> global_qtest variable, we should also make sure that nobody adds new code
> with this function again. qtest_hmp() should be used instead.
> Signed-off-by: Thomas Huth <address@hidden>
> ---
>  tests/libqtest.c | 11 -----------
>  tests/libqtest.h | 10 ----------
>  2 files changed, 21 deletions(-)


We could, at a later time, introduce a patch to do s/qtest_hmp/hmp/ if
it was deemed worthwhile, but I'm not sure it's worth the churn.

Reviewed-by: Eric Blake <address@hidden>

Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature

reply via email to

[Prev in Thread] Current Thread [Next in Thread]