[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-block] [Qemu-devel] [PATCH 2/3] iotests: Enable -d for Python

From: John Snow
Subject: Re: [Qemu-block] [Qemu-devel] [PATCH 2/3] iotests: Enable -d for Python non-unittest tests
Date: Tue, 6 Aug 2019 09:09:12 -0400
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0

On 8/6/19 5:51 AM, Kevin Wolf wrote:
> Am 06.08.2019 um 00:19 hat John Snow geschrieben:
>> On 8/2/19 10:07 AM, Kevin Wolf wrote:
>>> Am 01.08.2019 um 19:57 hat Max Reitz geschrieben:
>>>> On 01.08.19 17:17, Kevin Wolf wrote:
>>>>> The part of iotests.main() that is related to the implementation of the
>>>>> debug option -d and enables QEMU and QMP logging is not only useful in
>>>>> tests that use the Python unittest framework, but also in tests that
>>>>> work by comparing with a reference output.
>>>>> Factor these parts out into iotests.init() and call it from the test
>>>>> cases that currently lack support for debug output.
>>>> How does this relate to
>>>> https://lists.nongnu.org/archive/html/qemu-block/2019-07/msg01212.html ?
>>> Hm, no idea? :-)
>>> Looks like John's patch depends on some other patches which would then
>>> conflict with mine, too, so maybe I'll just drop my patch and wait what
>>> happens?
>>> John, any opinion?
>>> Kevin
>> My patches do roughly the same plus a little more. If you don't mind
>> waiting, I can take care of this for you when the tree reopens?
> Okay, I'll drop my patch then.
> Kevin

Thank you! I will try to fix my bitmaps branch ASAP in light of the
recent fixes and get this staged in an easy to test way for the 4.2 branch.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]