[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH for-4.1] util/hbitmap: update orig_size on trunc
Re: [Qemu-block] [PATCH for-4.1] util/hbitmap: update orig_size on truncate
Mon, 5 Aug 2019 14:19:20 +0200
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0
On 05.08.19 14:01, Vladimir Sementsov-Ogievskiy wrote:
> Without this, hbitmap_next_zero and hbitmap_next_dirty_area are broken
> after truncate. So, orig_size is broken since it's introduction in
> Fixes: 76d570dc495c56bb
> Signed-off-by: Vladimir Sementsov-Ogievskiy <address@hidden>
> Here is one more hbitmap bug I noticed. It's my fault, I'm sorry :(
> Broken in 4.0, but if we are already going to fix in 4.1 some things
> around it, it's a small meaningful addition.
> Users of broken API are incremental backup, sync mirror (but it may not
> be broken, if truncates not allowed during mirror, are they?),
It doesn’t appear that way (we don’t share BLK_PERM_RESIZE).
> bitmap export through NBD.
I suppose that counts as block-y enough for me to take it. Well, I’d
still like a test case to see the impact... I’ll see whether I can come
up with something.
> util/hbitmap.c | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
Reviewed-by: Max Reitz <address@hidden>
Description: OpenPGP digital signature