[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH 3/3] i386/kvm: initialize struct at full before
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-block] [PATCH 3/3] i386/kvm: initialize struct at full before ioctl call |
Date: |
Wed, 31 Jul 2019 15:03:01 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 |
On 31/07/19 14:43, Christian Borntraeger wrote:
>>>>>> if (has_xsave) {
>>>>>> env->xsave_buf = qemu_memalign(4096, sizeof(struct kvm_xsave));
>>>>>> + memset(env->xsave_buf, 0, sizeof(struct kvm_xsave));
> This is memsetting 4k?
> Yet another variant would be to use the RUNNING_ON_VALGRIND macro from
> valgrind/valgrind.h to only memset for valgrind. But just using
> MAKE_MEM_DEFINED
> from memcheck.h is simpler.
>
Yes, it's 4k but only at initialization time and I actually prefer not
to have potentially uninitialized host data in there.
Paolo
Re: [Qemu-block] [Qemu-devel] [PATCH 3/3] i386/kvm: initialize struct at full before ioctl call, Peter Maydell, 2019/07/30
Re: [Qemu-block] [PATCH 3/3] i386/kvm: initialize struct at full before ioctl call, Paolo Bonzini, 2019/07/30
- Re: [Qemu-block] [PATCH 3/3] i386/kvm: initialize struct at full before ioctl call, Christian Borntraeger, 2019/07/31
- Re: [Qemu-block] [PATCH 3/3] i386/kvm: initialize struct at full before ioctl call, Andrey Shinkevich, 2019/07/31
- Re: [Qemu-block] [PATCH 3/3] i386/kvm: initialize struct at full before ioctl call, Christian Borntraeger, 2019/07/31
- Re: [Qemu-block] [PATCH 3/3] i386/kvm: initialize struct at full before ioctl call, Christian Borntraeger, 2019/07/31
- Re: [Qemu-block] [PATCH 3/3] i386/kvm: initialize struct at full before ioctl call,
Paolo Bonzini <=
- Re: [Qemu-block] [PATCH 3/3] i386/kvm: initialize struct at full before ioctl call, Andrey Shinkevich, 2019/07/31
[Qemu-block] [PATCH 2/3] tests: Fix uninitialized byte in test_visitor_in_fuzz, Andrey Shinkevich, 2019/07/30
[Qemu-block] [PATCH 1/3] test-throttle: Fix uninitialized use of burst_length, Andrey Shinkevich, 2019/07/30