[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH for-4.1] block/copy-on-read: Fix permissions for
From: |
Max Reitz |
Subject: |
Re: [Qemu-block] [PATCH for-4.1] block/copy-on-read: Fix permissions for inactive node |
Date: |
Mon, 29 Jul 2019 17:31:02 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.2 |
On 29.07.19 12:53, Kevin Wolf wrote:
> The copy-on-read drive must not request the WRITE_UNCHANGED permission
> for its child if the node is inactive, otherwise starting a migration
> destination with -incoming will fail because the child cannot provide
> write access yet:
>
> qemu-system-x86_64: -blockdev copy-on-read,file=img,node-name=cor: Block
> node is read-only
>
> Earlier QEMU versions additionally ran into an abort() on the migration
> source side: bdrv_inactivate_recurse() failed to update permissions.
> This is silently ignored today because it was only supposed to loosen
> restrictions. This is the symptom that was originally reported here:
>
> https://bugzilla.redhat.com/show_bug.cgi?id=1733022
>
> Signed-off-by: Kevin Wolf <address@hidden>
> ---
> block/copy-on-read.c | 16 +++++++---------
> 1 file changed, 7 insertions(+), 9 deletions(-)
Reviewed-by: Max Reitz <address@hidden>
signature.asc
Description: OpenPGP digital signature