[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH v2 05/11] block: Use bdrv_has_zero_init_truncate
From: |
Max Reitz |
Subject: |
Re: [Qemu-block] [PATCH v2 05/11] block: Use bdrv_has_zero_init_truncate() |
Date: |
Fri, 26 Jul 2019 13:00:00 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.2 |
On 26.07.19 11:43, Stefano Garzarella wrote:
> On Wed, Jul 24, 2019 at 07:12:33PM +0200, Max Reitz wrote:
>> Signed-off-by: Max Reitz <address@hidden>
>> ---
>> block/parallels.c | 2 +-
>> block/vhdx.c | 2 +-
>> 2 files changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/block/parallels.c b/block/parallels.c
>> index 00fae125d1..7cd2714b69 100644
>> --- a/block/parallels.c
>> +++ b/block/parallels.c
>> @@ -835,7 +835,7 @@ static int parallels_open(BlockDriverState *bs, QDict
>> *options, int flags,
>> goto fail_options;
>> }
>>
>> - if (!bdrv_has_zero_init(bs->file->bs)) {
>> + if (!bdrv_has_zero_init_truncate(bs->file->bs)) {
>> s->prealloc_mode = PRL_PREALLOC_MODE_FALLOCATE;
>> }
>>
>> diff --git a/block/vhdx.c b/block/vhdx.c
>> index d6070b6fa8..a02d1c99a7 100644
>> --- a/block/vhdx.c
>> +++ b/block/vhdx.c
>> @@ -1282,7 +1282,7 @@ static coroutine_fn int
>> vhdx_co_writev(BlockDriverState *bs, int64_t sector_num,
>> /* Queue another write of zero buffers if the underlying
>> file
>> * does not zero-fill on file extension */
>>
>> - if (bdrv_has_zero_init(bs->file->bs) == 0) {
>> + if (bdrv_has_zero_init_truncate(bs->file->bs) == 0) {
>> use_zero_buffers = true;
>>
>> /* zero fill the front, if any */
>> --
>> 2.21.0
>>
>
> What about describing in the commit message why we are using
> bdrv_has_zero_init_truncate() like in the cover letter?
Sure. (Not sure why I didn’t do it in the first place.)
> With or without:
> Reviewed-by: Stefano Garzarella <address@hidden>
Thanks for reviewing!
Max
signature.asc
Description: OpenPGP digital signature
- [Qemu-block] [PATCH v2 03/11] block: Add bdrv_has_zero_init_truncate(), (continued)
- [Qemu-block] [PATCH v2 03/11] block: Add bdrv_has_zero_init_truncate(), Max Reitz, 2019/07/24
- [Qemu-block] [PATCH v2 04/11] block: Implement .bdrv_has_zero_init_truncate(), Max Reitz, 2019/07/24
- [Qemu-block] [PATCH v2 05/11] block: Use bdrv_has_zero_init_truncate(), Max Reitz, 2019/07/24
- [Qemu-block] [PATCH v2 06/11] qcow2: Fix .bdrv_has_zero_init(), Max Reitz, 2019/07/24
- [Qemu-block] [PATCH v2 07/11] vdi: Fix .bdrv_has_zero_init(), Max Reitz, 2019/07/24
- [Qemu-block] [PATCH v2 08/11] vhdx: Fix .bdrv_has_zero_init(), Max Reitz, 2019/07/24
- [Qemu-block] [PATCH v2 09/11] iotests: Convert to preallocated encrypted qcow2, Max Reitz, 2019/07/24
- [Qemu-block] [PATCH v2 10/11] iotests: Test convert -n to pre-filled image, Max Reitz, 2019/07/24