[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-block] [PATCH v3 for-4.1? 0/9] qcow2-bitmaps: rewrite reopening lo
From: |
Vladimir Sementsov-Ogievskiy |
Subject: |
[Qemu-block] [PATCH v3 for-4.1? 0/9] qcow2-bitmaps: rewrite reopening logic |
Date: |
Thu, 25 Jul 2019 12:18:51 +0300 |
Hi all!
Bitmaps reopening is buggy, we may easily produce broken incremental
backup if we do temporary snapshot. Let's fix it!
v3:
02: John's events_wait already merged in, so my 02 from v2 is not needed.
Instead, add two simple logging wrappers here
03: rebase on 02 - use new wrappers, move to 260
05: add John's r-b
06: improve function docs [John], add John's r-b
v2:
01: new
02-03: test: splat into two patches, some wording
improvements and event_wait improved
04: add John's r-b
05: new
06-09: fixes: changed, splat, use patch 01
Vladimir Sementsov-Ogievskiy (9):
block: add .bdrv_need_rw_file_child_during_reopen_rw handler
iotests.py: add event_wait_log and events_wait_log helpers
iotests: add test 260 to check bitmap life after snapshot + commit
block/qcow2-bitmap: get rid of bdrv_has_changed_persistent_bitmaps
block/qcow2-bitmap: drop qcow2_reopen_bitmaps_rw_hint()
block/qcow2-bitmap: do not remove bitmaps on reopen-ro
block/qcow2-bitmap: fix and improve qcow2_reopen_bitmaps_rw
block/qcow2-bitmap: fix reopening bitmaps to RW
qcow2-bitmap: move bitmap reopen-rw code to qcow2_reopen_prepare
block/qcow2.h | 6 +-
include/block/block_int.h | 8 +-
include/block/dirty-bitmap.h | 1 -
block.c | 163 +++++++++++++++++++++++++++-------
block/dirty-bitmap.c | 12 ---
block/qcow2-bitmap.c | 149 +++++++++++++++++++------------
block/qcow2.c | 9 +-
tests/qemu-iotests/260 | 87 ++++++++++++++++++
tests/qemu-iotests/260.out | 52 +++++++++++
tests/qemu-iotests/group | 1 +
tests/qemu-iotests/iotests.py | 10 +++
11 files changed, 384 insertions(+), 114 deletions(-)
create mode 100755 tests/qemu-iotests/260
create mode 100644 tests/qemu-iotests/260.out
--
2.18.0
- [Qemu-block] [PATCH v3 for-4.1? 0/9] qcow2-bitmaps: rewrite reopening logic,
Vladimir Sementsov-Ogievskiy <=
- [Qemu-block] [PATCH v3 2/9] iotests.py: add event_wait_log and events_wait_log helpers, Vladimir Sementsov-Ogievskiy, 2019/07/25
- [Qemu-block] [PATCH v3 7/9] block/qcow2-bitmap: fix and improve qcow2_reopen_bitmaps_rw, Vladimir Sementsov-Ogievskiy, 2019/07/25
- [Qemu-block] [PATCH v3 5/9] block/qcow2-bitmap: drop qcow2_reopen_bitmaps_rw_hint(), Vladimir Sementsov-Ogievskiy, 2019/07/25
- [Qemu-block] [PATCH v3 9/9] qcow2-bitmap: move bitmap reopen-rw code to qcow2_reopen_prepare, Vladimir Sementsov-Ogievskiy, 2019/07/25
- [Qemu-block] [PATCH v3 1/9] block: add .bdrv_need_rw_file_child_during_reopen_rw handler, Vladimir Sementsov-Ogievskiy, 2019/07/25
- [Qemu-block] [PATCH v3 8/9] block/qcow2-bitmap: fix reopening bitmaps to RW, Vladimir Sementsov-Ogievskiy, 2019/07/25
- [Qemu-block] [PATCH v3 3/9] iotests: add test 260 to check bitmap life after snapshot + commit, Vladimir Sementsov-Ogievskiy, 2019/07/25
- [Qemu-block] [PATCH v3 6/9] block/qcow2-bitmap: do not remove bitmaps on reopen-ro, Vladimir Sementsov-Ogievskiy, 2019/07/25
- [Qemu-block] [PATCH v3 4/9] block/qcow2-bitmap: get rid of bdrv_has_changed_persistent_bitmaps, Vladimir Sementsov-Ogievskiy, 2019/07/25