Re: [Qemu-block] [PATCH v6 02/14] qapi/block-core: add option for io_uring

[Eric Blake]

On 7/19/19 8:35 AM, Aarushi Mehta wrote:
> Only enumerates option for devices that support it
> 
> Signed-off-by: Aarushi Mehta <address@hidden>
> Reviewed-by: Stefan Hajnoczi <address@hidden>
> ---
>  qapi/block-core.json | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/qapi/block-core.json b/qapi/block-core.json
> index 0d43d4f37c..0a3d4ae7d2 100644
> --- a/qapi/block-core.json
> +++ b/qapi/block-core.json
> @@ -2792,11 +2792,13 @@
>  #
>  # @threads:     Use qemu's thread pool
>  # @native:      Use native AIO backend (only Linux and Windows)
> +# @io_uring:    Use linux io_uring (since 4.1)

I know you explained in an earlier revision why you chose 'io_uring'
instead of the more typical QAPI spelling of 'io-uring' (namely, it
matches the Linux kernel feature spelling).  That explanation belongs in
the commit message, rather than just the mailing list archives.

>  #
>  # Since: 2.9
>  ##
>  { 'enum': 'BlockdevAioOptions',
> -  'data': [ 'threads', 'native' ] }
> +  'data': [ 'threads', 'native',
> +            { 'name': 'io_uring', 'if': 'defined(CONFIG_LINUX_IO_URING)' } ] 
> }
>  
>  ##
>  # @BlockdevCacheOptions:
> 

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org

signature.asc
Description: OpenPGP digital signature