[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-block] [PATCH v2] gluster: fix .bdrv_reopen_prepare when backi

From: Max Reitz
Subject: Re: [Qemu-block] [PATCH v2] gluster: fix .bdrv_reopen_prepare when backing file is a JSON object
Date: Mon, 15 Jul 2019 15:44:13 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.2

On 15.07.19 15:28, Stefano Garzarella wrote:
> When the backing_file is specified as a JSON object, the
> qemu_gluster_reopen_prepare() fails with this message:
>     invalid URI json:{"server.0.host": ...}
> In this case, we should call qemu_gluster_init() using the QDict
> 'state->options' that contains the JSON parameters already parsed.
> Buglink: https://bugzilla.redhat.com/show_bug.cgi?id=1542445
> Signed-off-by: Stefano Garzarella <address@hidden>
> ---
> v2:
>     - check if 'state->bs->exact_filename' is empty, instead to parse
>       'state->bs->filename' to check if it contains "json:" [Max]
> ---
>  block/gluster.c | 12 +++++++++++-
>  1 file changed, 11 insertions(+), 1 deletion(-)

Thanks, applied to my block branch:



Attachment: signature.asc
Description: OpenPGP digital signature

reply via email to

[Prev in Thread] Current Thread [Next in Thread]