qemu-block
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-block] [Qemu-devel] [PATCH 7/7] iotests: Add test for image cr


From: Max Reitz
Subject: Re: [Qemu-block] [Qemu-devel] [PATCH 7/7] iotests: Add test for image creation fallback
Date: Mon, 15 Jul 2019 11:48:02 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.2

On 15.07.19 11:31, Thomas Huth wrote:
> On 12/07/2019 19.36, Max Reitz wrote:
>> Signed-off-by: Max Reitz <address@hidden>
>> ---
>>  tests/qemu-iotests/259     | 61 ++++++++++++++++++++++++++++++++++++++
>>  tests/qemu-iotests/259.out | 14 +++++++++
>>  tests/qemu-iotests/group   |  1 +
>>  3 files changed, 76 insertions(+)
>>  create mode 100755 tests/qemu-iotests/259
>>  create mode 100644 tests/qemu-iotests/259.out
>>
>> diff --git a/tests/qemu-iotests/259 b/tests/qemu-iotests/259
>> new file mode 100755
>> index 0000000000..22b4c10241
>> --- /dev/null
>> +++ b/tests/qemu-iotests/259
>> @@ -0,0 +1,61 @@
>> +#!/usr/bin/env bash
>> +#
>> +# Test generic image creation fallback (by using NBD)
>> +#
>> +# Copyright (C) 2019 Red Hat, Inc.
>> +#
>> +# This program is free software; you can redistribute it and/or modify
>> +# it under the terms of the GNU General Public License as published by
>> +# the Free Software Foundation; either version 2 of the License, or
>> +# (at your option) any later version.
>> +#
>> +# This program is distributed in the hope that it will be useful,
>> +# but WITHOUT ANY WARRANTY; without even the implied warranty of
>> +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
>> +# GNU General Public License for more details.
>> +#
>> +# You should have received a copy of the GNU General Public License
>> +# along with this program.  If not, see <http://www.gnu.org/licenses/>.
>> +#
>> +
>> +# creator
>> +owner=address@hidden
>> +
>> +seq=$(basename $0)
>> +echo "QA output created by $seq"
>> +
>> +status=1    # failure is the default!
>> +
>> +_cleanup()
>> +{
>> +    _cleanup_test_img
>> +}
>> +trap "_cleanup; exit \$status" 0 1 2 3 15
>> +
>> +# get standard environment, filters and checks
>> +. ./common.rc
>> +. ./common.filter
>> +
>> +_supported_fmt raw
> 
> Why is this stating "raw" here...
> 
>> +_supported_proto nbd

Because it’s an NBD test.

>> +_supported_os Linux
>> +
>> +
>> +_make_test_img 64M

Also, because I don‘t want this to create a qcow2 image.  This should
just set up a raw NBD node.

>> +echo
>> +echo '--- Testing creation ---'
>> +
>> +$QEMU_IMG create -f qcow2 "$TEST_IMG" 64M | _filter_img_create
> 
> ... and using qcow2 here instead?

Practical answer: Nobody tests qcow2+nbd.  Ever.  Because it is
generally a stupid combination.  We need it for this test, though,
because NBD is the simplest way to get a fixed-size block device.

The more involved answer is because nobody has introduced anything yet
to simply let the test decide on which format/protocol combination to
use by default (and then let the check script just use that, unless
overridden by the user).

But there‘s also the _make_test_img thing.

>> diff --git a/tests/qemu-iotests/group b/tests/qemu-iotests/group
>> index b34c8e3c0c..80e7603174 100644
>> --- a/tests/qemu-iotests/group
>> +++ b/tests/qemu-iotests/group
>> @@ -269,3 +269,4 @@
>>  254 rw auto backing quick
>>  255 rw auto quick
>>  256 rw auto quick
>> +259 rw auto quick
> 
> If this test only supports "raw", I think it should not be in the "auto"
> group anymore.

Oh, I didn‘t know that only runs qcow2 tests.  OK then.

Max

Attachment: signature.asc
Description: OpenPGP digital signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]