[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH 5/8] iotests/257: test API failures
From: |
Max Reitz |
Subject: |
Re: [Qemu-block] [PATCH 5/8] iotests/257: test API failures |
Date: |
Wed, 10 Jul 2019 18:22:49 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.0 |
On 10.07.19 03:05, John Snow wrote:
> Signed-off-by: John Snow <address@hidden>
> ---
> tests/qemu-iotests/257 | 69 +++++++++++++++++++++++++++++++
> tests/qemu-iotests/257.out | 85 ++++++++++++++++++++++++++++++++++++++
> 2 files changed, 154 insertions(+)
>
> diff --git a/tests/qemu-iotests/257 b/tests/qemu-iotests/257
> index 2eb4f26c28..de8707cb19 100755
> --- a/tests/qemu-iotests/257
> +++ b/tests/qemu-iotests/257
> @@ -450,10 +450,79 @@ def test_bitmap_sync(bsync_mode, msync_mode='bitmap',
> failure=None):
> compare_images(img_path, fbackup2)
> log('')
>
> +def test_backup_api():
> + """
> + """
Er, OK?
[...]
> + for sync_mode, config in error_cases.items():
> + log("-- Sync mode {:s} tests --\n".format(sync_mode))
> + for bitmap, policies in config.items():
You might be interested in the fact that the iteration order is
different for Python2. Or maybe you aren’t.
Reviewed-by: Max Reitz <address@hidden>
signature.asc
Description: OpenPGP digital signature
- Re: [Qemu-block] [PATCH 6/8] block/backup: issue progress updates for skipped regions, (continued)
[Qemu-block] [PATCH 4/8] block/backup: hoist bitmap check into QMP interface, John Snow, 2019/07/09
[Qemu-block] [PATCH 5/8] iotests/257: test API failures, John Snow, 2019/07/09
- Re: [Qemu-block] [PATCH 5/8] iotests/257: test API failures,
Max Reitz <=
[Qemu-block] [PATCH 7/8] block/backup: support bitmap sync modes for non-bitmap backups, John Snow, 2019/07/09
[Qemu-block] [PATCH 3/8] iotests/257: Refactor backup helpers, John Snow, 2019/07/09
[Qemu-block] [PATCH 8/8] iotests/257: test traditional sync modes, John Snow, 2019/07/09