[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-block] [PATCH for-4.1] qcow2: Allow -o compat=v3 during qemu-i

From: Eric Blake
Subject: Re: [Qemu-block] [PATCH for-4.1] qcow2: Allow -o compat=v3 during qemu-img amend
Date: Mon, 8 Jul 2019 14:15:10 -0500
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.0

On 7/8/19 11:51 AM, Kevin Wolf wrote:
> Am 05.07.2019 um 17:28 hat Eric Blake geschrieben:
>> Commit b76b4f60 allowed '-o compat=v3' as an alias for the
>> less-appealing '-o compat=1.1' for 'qemu-img create' since we want to
>> use the QMP form as much as possible, but forgot to do likewise for
>> qemu-img amend.  Also, it doesn't help that '-o help' doesn't list our
>> new preferred spellings.
>> Signed-off-by: Eric Blake <address@hidden>
> This broke qemu-iotests 082. Please send a follow-up to update the
> reference output.

I know that I did not specifically run iotests explicitly for this one
patch, but thought I had at least ran 'make check', since I know we've
been improving lately to run at least some of the iotests.

/me goes and rechecks...

well, 82 is definitely marked 'auto', and group claims that auto tests
will be run by 'make check', but that didn't trigger the failure for me.
 I wonder why?  At least I've posted the fix, as requested.

Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature

reply via email to

[Prev in Thread] Current Thread [Next in Thread]