[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH v2 02/18] drive-backup: create do_backup_common
|
From: |
John Snow |
|
Subject: |
Re: [Qemu-block] [PATCH v2 02/18] drive-backup: create do_backup_common |
|
Date: |
Fri, 5 Jul 2019 13:35:23 -0400 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.2 |
On 7/4/19 11:06 AM, Max Reitz wrote:
> On 03.07.19 23:55, John Snow wrote:
>> Create a common core that comprises the actual meat of what the backup API
>> boundary needs to do, and then switch drive-backup to use it.
>>
>> Questions:
>> - do_drive_backup now acquires and releases the aio_context in addition
>> to do_backup_common doing the same. Can I drop this from drive_backup?
>
> I wonder why you don’t just make it a requirement that
> do_backup_common() is called with the context acquired?
>
Oh, I remember: I wasn't actually sure if any of the calls that
drive-backup makes actually requires the AioContext. If that's true, no
reason to acquire it in two places and pass it in to the common function.
Probably bdrv_getlength and bdrv_refresh_filename both need it, though.
(Or at least, I can't promise they never wouldn't.)
--js
[Qemu-block] [PATCH v2 02/18] drive-backup: create do_backup_common, John Snow, 2019/07/03
[Qemu-block] [PATCH v2 03/18] blockdev-backup: utilize do_backup_common, John Snow, 2019/07/03
[Qemu-block] [PATCH v2 04/18] qapi: add BitmapSyncMode enum, John Snow, 2019/07/03
[Qemu-block] [PATCH v2 05/18] block/backup: Add mirror sync mode 'bitmap', John Snow, 2019/07/03
[Qemu-block] [PATCH v2 06/18] block/backup: add 'never' policy to bitmap sync mode, John Snow, 2019/07/03