[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH v3 2/6] block/nvme: fix doorbell stride
From: |
Max Reitz |
Subject: |
Re: [Qemu-block] [PATCH v3 2/6] block/nvme: fix doorbell stride |
Date: |
Fri, 5 Jul 2019 13:10:53 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.0 |
On 05.07.19 13:09, Max Reitz wrote:
> On 03.07.19 17:59, Maxim Levitsky wrote:
>> Fix the math involving non standard doorbell stride
>>
>> Signed-off-by: Maxim Levitsky <address@hidden>
>> ---
>> block/nvme.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/block/nvme.c b/block/nvme.c
>> index 6d4e7f3d83..52798081b2 100644
>> --- a/block/nvme.c
>> +++ b/block/nvme.c
>> @@ -217,7 +217,7 @@ static NVMeQueuePair
>> *nvme_create_queue_pair(BlockDriverState *bs,
>> error_propagate(errp, local_err);
>> goto fail;
>> }
>> - q->cq.doorbell = &s->regs->doorbells[idx * 2 * s->doorbell_scale + 1];
>> + q->cq.doorbell = &s->regs->doorbells[(idx * 2 + 1) * s->doorbell_scale];
>>
>> return q;
>> fail:
>
> Hm. How has this ever worked?
(Ah, because CAP.DSTRD has probably been 0 in most devices.)
signature.asc
Description: OpenPGP digital signature
- [Qemu-block] [PATCH v3 0/6] Few fixes for userspace NVME driver, Maxim Levitsky, 2019/07/03
- [Qemu-block] [PATCH v3 1/6] block/nvme: don't touch the completion entries, Maxim Levitsky, 2019/07/03
- Re: [Qemu-block] [PATCH v3 1/6] block/nvme: don't touch the completion entries, Max Reitz, 2019/07/05
- Re: [Qemu-block] [PATCH v3 1/6] block/nvme: don't touch the completion entries, Maxim Levitsky, 2019/07/07
- Re: [Qemu-block] [PATCH v3 1/6] block/nvme: don't touch the completion entries, Max Reitz, 2019/07/08
- Re: [Qemu-block] [PATCH v3 1/6] block/nvme: don't touch the completion entries, Maxim Levitsky, 2019/07/08
- Re: [Qemu-block] [PATCH v3 1/6] block/nvme: don't touch the completion entries, Max Reitz, 2019/07/08
- Re: [Qemu-block] [PATCH v3 1/6] block/nvme: don't touch the completion entries, Maxim Levitsky, 2019/07/08
[Qemu-block] [PATCH v3 2/6] block/nvme: fix doorbell stride, Maxim Levitsky, 2019/07/03
[Qemu-block] [PATCH v3 3/6] block/nvme: support larger that 512 bytes sector devices, Maxim Levitsky, 2019/07/03
[Qemu-block] [PATCH v3 5/6] block/nvme: add support for write zeros, Maxim Levitsky, 2019/07/03
[Qemu-block] [PATCH v3 4/6] block/nvme: add support for image creation, Maxim Levitsky, 2019/07/03