[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH v3] block/rbd: implement .bdrv_get_allocated_fil
From: |
Max Reitz |
Subject: |
Re: [Qemu-block] [PATCH v3] block/rbd: implement .bdrv_get_allocated_file_size callback |
Date: |
Fri, 5 Jul 2019 11:58:43 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.0 |
On 05.07.19 11:32, Stefano Garzarella wrote:
> This patch allows 'qemu-img info' to show the 'disk size' for
> the RBD images that have the fast-diff feature enabled.
>
> If this feature is enabled, we use the rbd_diff_iterate2() API
> to calculate the allocated size for the image.
>
> Signed-off-by: Stefano Garzarella <address@hidden>
> ---
> v3:
> - return -ENOTSUP instead of -1 when fast-diff is not available
> [John, Jason]
> v2:
> - calculate the actual usage only if the fast-diff feature is
> enabled [Jason]
> ---
> block/rbd.c | 54 +++++++++++++++++++++++++++++++++++++++++++++++++++++
> 1 file changed, 54 insertions(+)
Well, the librbd documentation is non-existing as always, but while
googling, I at least found that libvirt has exactly the same code. So I
suppose it must be quite correct, then.
> diff --git a/block/rbd.c b/block/rbd.c
> index 59757b3120..b6bed683e5 100644
> --- a/block/rbd.c
> +++ b/block/rbd.c
> @@ -1084,6 +1084,59 @@ static int64_t qemu_rbd_getlength(BlockDriverState *bs)
> return info.size;
> }
>
> +static int rbd_allocated_size_cb(uint64_t offset, size_t len, int exists,
> + void *arg)
> +{
> + int64_t *alloc_size = (int64_t *) arg;
> +
> + if (exists) {
> + (*alloc_size) += len;
> + }
> +
> + return 0;
> +}
> +
> +static int64_t qemu_rbd_get_allocated_file_size(BlockDriverState *bs)
> +{
> + BDRVRBDState *s = bs->opaque;
> + uint64_t flags, features;
> + int64_t alloc_size = 0;
> + int r;
> +
> + r = rbd_get_flags(s->image, &flags);
> + if (r < 0) {
> + return r;
> + }
> +
> + r = rbd_get_features(s->image, &features);
> + if (r < 0) {
> + return r;
> + }
> +
> + /*
> + * We use rbd_diff_iterate2() only if the RBD image have fast-diff
> + * feature enabled. If it is disabled, rbd_diff_iterate2() could be
> + * very slow on a big image.
> + */
> + if (!(features & RBD_FEATURE_FAST_DIFF) ||
> + (flags & RBD_FLAG_FAST_DIFF_INVALID)) {
> + return -ENOTSUP;
> + }
> +
> + /*
> + * rbd_diff_iterate2(), if the source snapshot name is NULL, invokes
> + * the callback on all allocated regions of the image.
> + */
> + r = rbd_diff_iterate2(s->image, NULL, 0,
> + bs->total_sectors * BDRV_SECTOR_SIZE, 0, 1,
> + &rbd_allocated_size_cb, &alloc_size);
But I have a question. This is basically block_status, right? So it
gives us information on which areas are allocated and which are not.
The result thus gives us a lower bound on the allocation size, but is it
really exactly the allocation size?
There are two things I’m concerned about:
1. What about metadata?
2. If you have multiple snapshots, this will only report the overall
allocation information, right? So say there is something like this:
(“A” means an allocated MB, “-” is an unallocated MB)
Snapshot 1: AAAA---
Snapshot 2: --AAAAA
Snapshot 3: -AAAA--
I think the allocated data size is the number of As in total (13 MB).
But I suppose this API will just return 7 MB, because it looks on
everything an it sees the whole image range (7 MB) to be allocated. It
doesn’t report in how many snapshots some region is allocated.
Max
> + if (r < 0) {
> + return r;
> + }
> +
> + return alloc_size;
> +}
> +
> static int coroutine_fn qemu_rbd_co_truncate(BlockDriverState *bs,
> int64_t offset,
> PreallocMode prealloc,
> @@ -1291,6 +1344,7 @@ static BlockDriver bdrv_rbd = {
> .bdrv_get_info = qemu_rbd_getinfo,
> .create_opts = &qemu_rbd_create_opts,
> .bdrv_getlength = qemu_rbd_getlength,
> + .bdrv_get_allocated_file_size = qemu_rbd_get_allocated_file_size,
> .bdrv_co_truncate = qemu_rbd_co_truncate,
> .protocol_name = "rbd",
>
>
signature.asc
Description: OpenPGP digital signature
- [Qemu-block] [PATCH v3] block/rbd: implement .bdrv_get_allocated_file_size callback, Stefano Garzarella, 2019/07/05
- Re: [Qemu-block] [PATCH v3] block/rbd: implement .bdrv_get_allocated_file_size callback,
Max Reitz <=
- Re: [Qemu-block] [PATCH v3] block/rbd: implement .bdrv_get_allocated_file_size callback, Stefano Garzarella, 2019/07/05
- Re: [Qemu-block] [PATCH v3] block/rbd: implement .bdrv_get_allocated_file_size callback, Jason Dillaman, 2019/07/08
- Re: [Qemu-block] [PATCH v3] block/rbd: implement .bdrv_get_allocated_file_size callback, Max Reitz, 2019/07/09
- Re: [Qemu-block] [PATCH v3] block/rbd: implement .bdrv_get_allocated_file_size callback, Max Reitz, 2019/07/09
- Re: [Qemu-block] [PATCH v3] block/rbd: implement .bdrv_get_allocated_file_size callback, Jason Dillaman, 2019/07/09
- Re: [Qemu-block] [PATCH v3] block/rbd: implement .bdrv_get_allocated_file_size callback, Stefano Garzarella, 2019/07/09
- Re: [Qemu-block] [PATCH v3] block/rbd: implement .bdrv_get_allocated_file_size callback, Max Reitz, 2019/07/09
- Re: [Qemu-block] [PATCH v3] block/rbd: implement .bdrv_get_allocated_file_size callback, Jason Dillaman, 2019/07/09
- Re: [Qemu-block] [PATCH v3] block/rbd: implement .bdrv_get_allocated_file_size callback, Stefano Garzarella, 2019/07/10