[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [Qemu-devel] [PATCH 4/5] iotests: Add @use_log to VM.ru
Re: [Qemu-block] [Qemu-devel] [PATCH 4/5] iotests: Add @use_log to VM.run_job()
Tue, 2 Jul 2019 16:21:31 -0400
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.2
On 7/2/19 12:19 PM, Max Reitz wrote:
> On 02.07.19 00:59, John Snow wrote:
>> On 6/27/19 6:32 PM, Max Reitz wrote:
>>> unittest-style tests generally do not use the log file, but VM.run_job()
>>> can still be useful to them. Add a parameter to it that hides its
>>> output from the log file.
>>> Signed-off-by: Max Reitz <address@hidden>
>> Wondering out loud:
>> can log() (and by extension qmp_log, and run_job) be made to use the
>> python logging module and we can configure the logging environment
>> instead of bespoke arguments to avoid ever engaging the log?
>> We could theoretically just pre-disable iotests log output for unittest
>> style tests, unless you run in debug mode where we allow it.
>> I don't have a specific proposal for how to accomplish this, I think
>> there are some nuances to Python logging that I don't quite understand.
>> Maybe Cleber Rosa can help advise?
>> I'd like to toy with this idea; it seems like this won't be the last
>> time we want to turn output on/off.
> Sounds good. But considering this is just test infrastructure, I’ll
> leave that for when someone(TM) gets around to doing it. (Hopefully
> when the next function is about to get a @use_log parameter.)
I just noticed that our pal run_job is getting a little long in the
arguments list, which is a good hint that we're doing something wrong.
I'll try to look into this as part of my next bitmap set.