[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [Qemu-devel] [RFC PATCH v2 0/3] python: refactor qemu/_
Re: [Qemu-block] [Qemu-devel] [RFC PATCH v2 0/3] python: refactor qemu/__init__.py
Mon, 1 Jul 2019 19:17:39 -0400
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.2
On 7/1/19 5:27 PM, Eduardo Habkost wrote:
> On Thu, Jun 27, 2019 at 05:32:17PM -0400, John Snow wrote:
>> I didn't actually mean to retain the RFC tag, but oh well.
> I'm queueing patch 1-2 for QEMU 4.1.
> Patch 3 will require more careful review. If you can demonstrate
> it fixes a problem in some use cases, we can call it a bug fix
> and include it after soft freeze. ;)
Mostly, it's that it ignores things like ctrl^c -- it ignores ANY
failure. I don't think that it should.
In cases where QEMU crashes, the caller will now get an exception -- but
the cleanup will still faithfully execute. There are some exceptions we
may genuinely wish to suppress here, but it's hard to enumerate which
ones without going too broadly.
It's fine to exclude this for now, but I think it's still something we