[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [Qemu-devel] [PATCH v2 1/5] iotests: Add -display none
From: |
Philippe Mathieu-Daudé |
Subject: |
Re: [Qemu-block] [Qemu-devel] [PATCH v2 1/5] iotests: Add -display none to the qemu options |
Date: |
Wed, 26 Jun 2019 12:36:05 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.0 |
On 6/25/19 11:19 PM, Max Reitz wrote:
> Without this argument, qemu will print an angry message about not being
> able to connect to a display server if $DISPLAY is not set. For me,
> that breaks iotests.supported_formats() because it thus only sees
> ["Could", "not", "connect"] as the supported formats.
>
> Signed-off-by: Max Reitz <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
> ---
> tests/qemu-iotests/check | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/tests/qemu-iotests/check b/tests/qemu-iotests/check
> index f925606cc5..f2a0df8af2 100755
> --- a/tests/qemu-iotests/check
> +++ b/tests/qemu-iotests/check
> @@ -581,13 +581,13 @@ export QEMU_PROG="$(type -p "$QEMU_PROG")"
>
> case "$QEMU_PROG" in
> *qemu-system-arm|*qemu-system-aarch64)
> - export QEMU_OPTIONS="-nodefaults -machine virt,accel=qtest"
> + export QEMU_OPTIONS="-nodefaults -display none -machine
> virt,accel=qtest"
> ;;
> *qemu-system-tricore)
> - export QEMU_OPTIONS="-nodefaults -machine
> tricore_testboard,accel=qtest"
> + export QEMU_OPTIONS="-nodefaults -display none -machine
> tricore_testboard,accel=qtest"
> ;;
> *)
> - export QEMU_OPTIONS="-nodefaults -machine accel=qtest"
> + export QEMU_OPTIONS="-nodefaults -display none -machine accel=qtest"
> ;;
> esac
>
>
- [Qemu-block] [PATCH v2 0/5] iotests: Selfish patches, Max Reitz, 2019/06/25
- [Qemu-block] [PATCH v2 1/5] iotests: Add -display none to the qemu options, Max Reitz, 2019/06/25
- Re: [Qemu-block] [Qemu-devel] [PATCH v2 1/5] iotests: Add -display none to the qemu options,
Philippe Mathieu-Daudé <=
- [Qemu-block] [PATCH v2 2/5] iotests: Prefer null-co over null-aio, Max Reitz, 2019/06/25
- [Qemu-block] [PATCH v2 4/5] iotests: Test driver whitelisting in 093, Max Reitz, 2019/06/25
- [Qemu-block] [PATCH v2 5/5] iotests: Test driver whitelisting in 136, Max Reitz, 2019/06/25
- [Qemu-block] [PATCH v2 3/5] iotests: Allow skipping test cases, Max Reitz, 2019/06/25