[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH 05/12] hbitmap: enable merging across granularit
|
From: |
Vladimir Sementsov-Ogievskiy |
|
Subject: |
Re: [Qemu-block] [PATCH 05/12] hbitmap: enable merging across granularities |
|
Date: |
Fri, 21 Jun 2019 11:45:39 +0000 |
20.06.2019 19:47, Max Reitz wrote:
> On 20.06.19 03:03, John Snow wrote:
>> Signed-off-by: John Snow <address@hidden>
>> ---
>> util/hbitmap.c | 22 +++++++++++++++++++++-
>> 1 file changed, 21 insertions(+), 1 deletion(-)
>
> I wonder whether this could be used in
> backup_incremental_init_copy_bitmap(). The sync_bitmap must have the
> same length as the source BDS, right?
>
A little problem here is that in backup code we merge BdrvDirtyBitmap into
HBitmap, so hbitmap API can't be directly used here, and to avoid code
duplication we need to create a bit strange interface of merging exactly
BdrvDirtyBitmap into HBitmap.. But, anyway it's better than code duplication.
Yes, they should have the same length.
But we may allow at least merging smaller bitmap into larger, why not?
--
Best regards,
Vladimir
- Re: [Qemu-block] [Qemu-devel] [PATCH 02/12] block/backup: Add mirror sync mode 'bitmap', (continued)
[Qemu-block] [PATCH 05/12] hbitmap: enable merging across granularities, John Snow, 2019/06/19
[Qemu-block] [PATCH 11/12] iotests: add test 257 for bitmap-mode backups, John Snow, 2019/06/19
[Qemu-block] [PATCH 03/12] block/backup: add 'never' policy to bitmap sync mode, John Snow, 2019/06/19