[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [Qemu-devel] [PATCH 1/7] iotests: allow Valgrind checki
From: |
Andrey Shinkevich |
Subject: |
Re: [Qemu-block] [Qemu-devel] [PATCH 1/7] iotests: allow Valgrind checking all QEMU processes |
Date: |
Mon, 10 Jun 2019 15:02:35 +0000 |
On 10/06/2019 17:24, Eric Blake wrote:
> On 6/9/19 1:35 PM, Andrey Shinkevich wrote:
>> With the '-valgrind' option, let all the QEMU processes be run under
>> the Valgrind tool. The Valgrind own parameters may be set with its
>> environment variable VALGRIND_OPTS, e.g.
>> VALGRIND_OPTS="--leak-check=yes" ./check -qcow2 -valgrind <test#>
>
> Let's spell this --valgrind; long options should prefer the use of --
> (as in getopt_long), whether or not we also have a reason to support
> -valgrind (as in getopt_long_only). Yes, qemu is an oddball in this
> regards, but no need to make it worse.
>
Thank you, Eric. That sounds good but the short option'-valgrind' is
preexisting in QEMU. Should I create a new patch for the long option?
If so, will we have both options supported by QEMU?
Andrey
>>
>> Signed-off-by: Andrey Shinkevich <address@hidden>
>> ---
>> tests/qemu-iotests/common.rc | 65
>> ++++++++++++++++++++++++++++++++------------
>> 1 file changed, 48 insertions(+), 17 deletions(-)
>>
>> diff --git a/tests/qemu-iotests/common.rc b/tests/qemu-iotests/common.rc
>> index 93f8738..3caaca4 100644
>
>
--
With the best regards,
Andrey Shinkevich