[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH v4 4.5/6] qapi: Replace QAPIDoc._part by ._appen
|
From: |
Kevin Wolf |
|
Subject: |
Re: [Qemu-block] [PATCH v4 4.5/6] qapi: Replace QAPIDoc._part by ._append_line, and rework comments |
|
Date: |
Thu, 6 Jun 2019 15:21:39 +0200 |
|
User-agent: |
Mutt/1.11.3 (2019-02-01) |
Am 06.06.2019 um 14:01 hat Markus Armbruster geschrieben:
> Signed-off-by: Markus Armbruster <address@hidden>
> ---
> This is on top of the fixup I appended to my review of v4. I'd squash
> all three patches together.
>
> The next patch needs to be updated for this.
>
> Unsquashed branch at git://repo.or.cz/qemu/armbru.git branch
> qapi-features.
>
> Let me know what you think.
As you know, I don't like the self._append_line function pointer and
think it makes the code less readable. However, I also hope that I'll
never have to touch this code again, whereas you as the maintainer will
probably have to. So your taste is more imporant than mine.
So for all I care, go ahead and squash in your changes.
Kevin