Re: [Qemu-block] [Qemu-devel] [PULL 00/28] Block layer patches

[no-reply]

Patchew URL: https://patchew.org/QEMU/address@hidden/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Subject: [Qemu-devel] [PULL 00/28] Block layer patches
Type: series
Message-id: address@hidden

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

From https://github.com/patchew-project/qemu
   ad88e4252f..e2a58ff493  master     -> master
From https://github.com/patchew-project/qemu
 * [new tag]               patchew/address@hidden -> patchew/address@hidden
Switched to a new branch 'test'
220e753b45 iotests: Fix duplicated diff output on failure
0b71e618fa block/io: bdrv_pdiscard: support int64_t bytes parameter
e7a4ac900f block/qcow2-refcount: add trace-point to qcow2_process_discards
4dad653c53 block: Remove bdrv_set_aio_context()
3ab629f6ae test-bdrv-drain: Use bdrv_try_set_aio_context()
a2c999ab92 iotests: Attach new devices to node in non-default iothread
9882a15cb7 virtio-scsi-test: Test attaching new overlay with iothreads
bad8ab68a2 block: Remove wrong bdrv_set_aio_context() calls
4b94672417 blockdev: Use bdrv_try_set_aio_context() for monitor commands
ac65c7ccfd block: Move node without parents to main AioContext
f3f5afac50 test-block-iothread: BlockBackend AioContext across root node change
5be6b76fd8 test-block-iothread: Test adding parent to iothread node
d44a5b97a1 block: Adjust AioContexts when attaching nodes
032072dbdd scsi-disk: Use qdev_prop_drive_iothread
08213d11da block: Add qdev_prop_drive_iothread property type
3143af0939 block: Add BlockBackend.ctx
0218a8120b block: Add Error to blk_set_aio_context()
8dec7e6e5d nbd-server: Call blk_set_allow_aio_context_change()
4fab052a83 test-block-iothread: Check filter node in test_propagate_mirror
bec547ff8c nvme: add Get/Set Feature Timestamp support
daedce9044 block/linux-aio: Drop unused BlockAIOCB submission method
a620ab7c2f iotests: Test cancelling a job and closing the VM
b13df9380c block/io: Delay decrementing the quiesce_counter
96436a8e4d block: avoid recursive block_status call if possible
3b06eca03a tests/perf: Test lseek influence on qcow2 block-status
24a7a53346 blockdev: fix missed target unref for drive-backup
73ec47bcf8 iotests: Test commit job start with concurrent I/O
c8758f4aab block: Drain source node in bdrv_replace_node()

=== OUTPUT BEGIN ===
1/28 Checking commit c8758f4aabfc (block: Drain source node in 
bdrv_replace_node())
2/28 Checking commit 73ec47bcf823 (iotests: Test commit job start with 
concurrent I/O)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#16: 
new file mode 100755

total: 0 errors, 1 warnings, 131 lines checked

Patch 2/28 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
3/28 Checking commit 24a7a533464e (blockdev: fix missed target unref for 
drive-backup)
4/28 Checking commit 3b06eca03aff (tests/perf: Test lseek influence on qcow2 
block-status)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#20: 
new file mode 100755

total: 0 errors, 1 warnings, 71 lines checked

Patch 4/28 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
5/28 Checking commit 96436a8e4dba (block: avoid recursive block_status call if 
possible)
6/28 Checking commit b13df9380cc9 (block/io: Delay decrementing the 
quiesce_counter)
7/28 Checking commit a620ab7c2f73 (iotests: Test cancelling a job and closing 
the VM)
8/28 Checking commit daedce9044d9 (block/linux-aio: Drop unused BlockAIOCB 
submission method)
9/28 Checking commit bec547ff8ce6 (nvme: add Get/Set Feature Timestamp support)
10/28 Checking commit 4fab052a83c2 (test-block-iothread: Check filter node in 
test_propagate_mirror)
11/28 Checking commit 8dec7e6e5db9 (nbd-server: Call 
blk_set_allow_aio_context_change())
12/28 Checking commit 0218a8120b5c (block: Add Error to blk_set_aio_context())
WARNING: Block comments use a leading /* on a separate line
#104: FILE: hw/block/dataplane/virtio-blk.c:289:
+    /* Drain and try to switch bs back to the QEMU main loop. If other users

WARNING: Block comments use a trailing */ on a separate line
#105: FILE: hw/block/dataplane/virtio-blk.c:290:
+     * keep the BlockBackend in the iothread, that's ok */

total: 0 errors, 2 warnings, 259 lines checked

Patch 12/28 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
13/28 Checking commit 3143af09391d (block: Add BlockBackend.ctx)
WARNING: Block comments use a leading /* on a separate line
#96: FILE: block/block-backend.c:1864:
+    /* FIXME The AioContext of bs and blk can be inconsistent. For the moment,

WARNING: Block comments use a trailing */ on a separate line
#97: FILE: block/block-backend.c:1865:
+     * we prefer the one of bs for compatibility. */

WARNING: Block comments use a leading /* on a separate line
#405: FILE: hw/core/qdev-properties-system.c:83:
+            /* BlockBackends of devices start in the main context and are only

WARNING: Block comments use a trailing */ on a separate line
#406: FILE: hw/core/qdev-properties-system.c:84:
+             * later moved into another context if the device supports that. */

total: 0 errors, 4 warnings, 553 lines checked

Patch 13/28 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
14/28 Checking commit 08213d11da90 (block: Add qdev_prop_drive_iothread 
property type)
ERROR: Macros with complex values should be enclosed in parenthesis
#133: FILE: include/hw/block/block.h:61:
+#define DEFINE_BLOCK_PROPERTIES(_state, _conf)                          \
+    DEFINE_PROP_DRIVE("drive", _state, _conf.blk),                      \
+    DEFINE_BLOCK_PROPERTIES_BASE(_state, _conf)

total: 1 errors, 0 warnings, 107 lines checked

Patch 14/28 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

15/28 Checking commit 032072dbdd61 (scsi-disk: Use qdev_prop_drive_iothread)
ERROR: Macros with complex values should be enclosed in parenthesis
#49: FILE: hw/scsi/scsi-disk.c:2939:
+#define DEFINE_SCSI_DISK_PROPERTIES()                                   \
+    DEFINE_PROP_DRIVE_IOTHREAD("drive", SCSIDiskState, qdev.conf.blk),  \
+    DEFINE_BLOCK_PROPERTIES_BASE(SCSIDiskState, qdev.conf),             \
+    DEFINE_BLOCK_ERROR_PROPERTIES(SCSIDiskState, qdev.conf),            \
+    DEFINE_PROP_STRING("ver", SCSIDiskState, version),                  \
+    DEFINE_PROP_STRING("serial", SCSIDiskState, serial),                \
+    DEFINE_PROP_STRING("vendor", SCSIDiskState, vendor),                \
+    DEFINE_PROP_STRING("product", SCSIDiskState, product),              \
     DEFINE_PROP_STRING("device_id", SCSIDiskState, device_id)

total: 1 errors, 0 warnings, 85 lines checked

Patch 15/28 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

16/28 Checking commit d44a5b97a1ee (block: Adjust AioContexts when attaching 
nodes)
WARNING: Block comments use a leading /* on a separate line
#47: FILE: block.c:2284:
+    /* If the AioContexts don't match, first try to move the subtree of

WARNING: Block comments use a trailing */ on a separate line
#49: FILE: block.c:2286:
+     * try moving the parent into the AioContext of child_bs instead. */

total: 0 errors, 2 warnings, 152 lines checked

Patch 16/28 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
17/28 Checking commit 5be6b76fd8f3 (test-block-iothread: Test adding parent to 
iothread node)
18/28 Checking commit f3f5afac5053 (test-block-iothread: BlockBackend 
AioContext across root node change)
19/28 Checking commit ac65c7ccfd70 (block: Move node without parents to main 
AioContext)
WARNING: Block comments use a leading /* on a separate line
#23: FILE: block.c:2239:
+        /* When the parent requiring a non-default AioContext is removed, the

WARNING: Block comments use a trailing */ on a separate line
#24: FILE: block.c:2240:
+         * node moves back to the main AioContext */

total: 0 errors, 2 warnings, 28 lines checked

Patch 19/28 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
20/28 Checking commit 4b94672417f0 (blockdev: Use bdrv_try_set_aio_context() 
for monitor commands)
21/28 Checking commit bad8ab68a251 (block: Remove wrong bdrv_set_aio_context() 
calls)
22/28 Checking commit 9882a15cb739 (virtio-scsi-test: Test attaching new 
overlay with iothreads)
23/28 Checking commit a2c999ab92aa (iotests: Attach new devices to node in 
non-default iothread)
24/28 Checking commit 3ab629f6aeaf (test-bdrv-drain: Use 
bdrv_try_set_aio_context())
25/28 Checking commit 4dad653c533e (block: Remove bdrv_set_aio_context())
26/28 Checking commit e7a4ac900f2f (block/qcow2-refcount: add trace-point to 
qcow2_process_discards)
27/28 Checking commit 0b71e618fa6e (block/io: bdrv_pdiscard: support int64_t 
bytes parameter)
28/28 Checking commit 220e753b4588 (iotests: Fix duplicated diff output on 
failure)
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/address@hidden/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to address@hidden