[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH v2] hw/block/fdc: floppy command FIFO memory ini
From: |
Andrey Shinkevich |
Subject: |
Re: [Qemu-block] [PATCH v2] hw/block/fdc: floppy command FIFO memory initialization |
Date: |
Thu, 30 May 2019 06:47:50 +0000 |
On 30/05/2019 00:38, Max Reitz wrote:
> On 29.05.19 20:20, Andrey Shinkevich wrote:
>> The uninitialized memory allocated for the command FIFO of the
>> floppy controller during the VM hardware initialization incurs
>> many unwanted reports by Valgrind when VM state is being saved.
>> That verbosity hardens a search for the real memory issues when
>> the iotests run. Particularly, the patch eliminates 20 unnecessary
>> reports of the Valgrind tool in the iotest #169.
>>
>> Signed-off-by: Andrey Shinkevich <address@hidden>
>> ---
>> v2:
>> 01: The pointer unnecessary check 'if (fdctrl->fifo)' was removed
>> as suggested by John.
>>
>> hw/block/fdc.c | 1 +
>> 1 file changed, 1 insertion(+)
>
> Thanks, applied to my block-on-kevin branch:
>
> https://git.xanclic.moe/XanClic/qemu/commits/branch/block-on-kevin
>
> (To become my block branch when my current pull request is done.)
>
> Max
>
Thank you very much.
Andrey