[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-block] [Qemu-devel] [PATCH v2 1/6] qapi: Support features for

From: Eric Blake
Subject: Re: [Qemu-block] [Qemu-devel] [PATCH v2 1/6] qapi: Support features for structs
Date: Fri, 24 May 2019 09:50:56 -0500
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1

On 5/24/19 8:20 AM, Markus Armbruster wrote:
> "Support features for structs" accidentally fits the "Do stuff"
> commit message anti-pattern.  Suggest:
>     qapi: Add feature flags to struct types

>> +# @features: names of features that are supported by this version and build 
>> and
>> +#            aren't othervise visible through schema introspection (e.g. 
>> change


>> +#            of behaviour related to an object type that didn't come with a

Do we have a strong US or UK preference on spelling in user-visible
docs? (US would use "behavior")

>> +#            syntactic change in the schema of the object type) (since: 4.1)
>> +#
> Specify "in no particular order", like we do elsewhere.
> Let's wrap lines a little earlier.
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature

reply via email to

[Prev in Thread] Current Thread [Next in Thread]