[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-block] [PATCH v2 1/3] qemu-img: rebase: Reuse parent BlockDriv

From: Max Reitz
Subject: Re: [Qemu-block] [PATCH v2 1/3] qemu-img: rebase: Reuse parent BlockDriverState
Date: Thu, 23 May 2019 15:07:14 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1

On 02.05.19 15:58, Sam Eiderman wrote:
> In safe mode we open the entire chain, including the parent backing
> file of the rebased file.
> Do not open a new BlockBackend for the parent backing file, which
> saves opening the rest of the chain twice, which for long chains
> saves many "pricy" bdrv_open() calls.
> Permissions for blk_new() were copied from blk_new_open() when
> flags = 0.
> Reviewed-by: Karl Heubaum <address@hidden>
> Reviewed-by: Eyal Moscovici <address@hidden>
> Signed-off-by: Sagi Amit <address@hidden>
> Co-developed-by: Sagi Amit <address@hidden>
> Signed-off-by: Sam Eiderman <address@hidden>
> ---
>  qemu-img.c | 29 ++++++++++++-----------------
>  1 file changed, 12 insertions(+), 17 deletions(-)

Looks good!
But I’m afraid it will need a rebase on my “Allow rebase with no input
base” series (which is in master)...


Attachment: signature.asc
Description: OpenPGP digital signature

reply via email to

[Prev in Thread] Current Thread [Next in Thread]