[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH v3] tests/qemu-iotests: re-format output to for
Re: [Qemu-block] [PATCH v3] tests/qemu-iotests: re-format output to for make check-block
Wed, 22 May 2019 16:29:57 +0100
mu4e 1.3.2; emacs 26.1
Kevin Wolf <address@hidden> writes:
> Am 10.05.2019 um 12:29 hat Alex Bennée geschrieben:
>> This attempts to clean-up the output to better match the output of the
>> rest of the QEMU check system when called with -pretty. This includes:
>> - formatting as " TEST iotest: nnn"
>> - calculating time diff at the end
>> - only dumping config on failure (when -pretty enabled)
>> The existing output is mostly preserved although the dumping of the
>> old time at the start "Ns ..." was removed to keep the logic simple.
>> The timestamp mode can still be used to see which tests are "hanging".
>> Signed-off-by: Alex Bennée <address@hidden>
>> Message-Id: <address@hidden>
> I played with it a bit more and ended up with the following patch to be
> applied on top. Maybe you like some parts of it.
> I'm now printing an \r at the end of the line that is printed at the
> start of the test case. Normally that will be overwritten by the result
> line which contains the same information again, but if you're running
> multiple tests in parallel, it will be overwritten by something else -
> which I think isn't a big problem because at the end, the result line
> will still appear somewhere.
> I fixed some bugs, too, like the "not run" list being broken.
Thanks, I've merged those changes in with a few minor tweaks for the
makecheck version (single phase output, dropped the defunct -T option).
I'll send out testing/next shortly.