[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [Qemu-devel] [RFC PATCH 1/9] qapi/block-core: add optio
|
From: |
Eric Blake |
|
Subject: |
Re: [Qemu-block] [Qemu-devel] [RFC PATCH 1/9] qapi/block-core: add option for io_uring |
|
Date: |
Tue, 21 May 2019 20:01:59 -0500 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 |
On 5/21/19 7:51 PM, Aarushi Mehta wrote:
>>> +# @io_uring: Use linux io_uring
>>
>> Missing a '(since 4.1)' tag.
>>
>>> #
>>> # Since: 2.9
>>> ##
>>> { 'enum': 'BlockdevAioOptions',
>>> - 'data': [ 'threads', 'native' ] }
>>> + 'data': [ 'threads', 'native','io_uring' ] }
>>
>> Missing space after ',' (not essential, but matching style is nice).
>> Should the new element be defined conditionally, so that
>> introspection
>> only sees the new enum member when compiled for Linux?
>>
> I'm not sure what would be the benefits of that? We already check for
> Linux at configure, and this would reduce readability. We aren't doing
> this for native.
Look at BlockdevOptionsFile in qapi/block-core.qapi. Telling the QAPI
generator that something is only available on Linux means that it will
be obvious to introspection (the QMP command query-qmp-schema) whether
the feature is present in a particular binary.
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature
- Re: [Qemu-block] [Qemu-devel] [RFC PATCH 5/9] util/asyn: add aio interfaces for io_uring, (continued)
- [Qemu-block] [RFC PATCH 2/9] block/block: add BDRV flag for io_uring, Aarushi Mehta, 2019/05/21
- [Qemu-block] [RFC PATCH 8/9] block/file-posix: extends to use with io_uring, Aarushi Mehta, 2019/05/21
- [Qemu-block] [RFC PATCH 7/9] blockdev: accept io_uring as option, Aarushi Mehta, 2019/05/21
- [Qemu-block] [RFC PATCH 6/9] block/io_uring: implements interfaces for io_uring, Aarushi Mehta, 2019/05/21
- [Qemu-block] [RFC PATCH 1/9] qapi/block-core: add option for io_uring, Aarushi Mehta, 2019/05/21
- Re: [Qemu-block] [Qemu-devel] [RFC PATCH 0/9] Add support for io_uring, Stefan Hajnoczi, 2019/05/22
- [Qemu-block] [RFC PATCH 0/9] Add support for io_uring, Aarushi Mehta, 2019/05/21
- [Qemu-block] [RFC PATCH 8/9] block/file-posix: extends to use with io_uring, Aarushi Mehta, 2019/05/21
- [Qemu-block] [RFC PATCH 9/9] configure: permits use of io_uring with probe, Aarushi Mehta, 2019/05/21
- [Qemu-block] [RFC PATCH 4/9] stubs: add aio interface stubs for io_uring, Aarushi Mehta, 2019/05/21
- [Qemu-block] [RFC PATCH 6/9] block/io_uring: implements interfaces for io_uring, Aarushi Mehta, 2019/05/21
- [Qemu-block] [RFC PATCH 7/9] blockdev: accept io_uring as option, Aarushi Mehta, 2019/05/21
- [Qemu-block] [RFC PATCH 3/9] include/block: declare interfaces for io_uring, Aarushi Mehta, 2019/05/21