[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH v2 1/2] qapi: support external bitmaps in block-
|
From: |
Eric Blake |
|
Subject: |
Re: [Qemu-block] [PATCH v2 1/2] qapi: support external bitmaps in block-dirty-bitmap-merge |
|
Date: |
Mon, 20 May 2019 10:23:48 -0500 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 |
On 5/17/19 5:45 PM, John Snow wrote:
>
>
> On 5/17/19 11:21 AM, Vladimir Sementsov-Ogievskiy wrote:
>> Add new optional parameter making possible to merge bitmaps from
>> different nodes. It is needed to maintain external snapshots during
>> incremental backup chain history.
>>
>> Signed-off-by: Vladimir Sementsov-Ogievskiy <address@hidden>
>> ---
>> +# Since: 4.1
>> +##
>> +{ 'alternate': 'BlockDirtyBitmapMergeSource',
>> + 'data': { 'local': 'str',
>> + 'external': 'BlockDirtyBitmap' } }
>> +
>
> We might be able to use something more generic to name this type of
> thing, but I think such changes are wire compatible, so we can rename it
> to be more generic if we decide to use this for something else in the
> future, so this is good.
Correct - type names are not API, so we can rename them later if it
makes sense.
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature