[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-block] [PATCH] nbd/server: Nicer spelling of max BLOCK_STATUS

From: Vladimir Sementsov-Ogievskiy
Subject: Re: [Qemu-block] [PATCH] nbd/server: Nicer spelling of max BLOCK_STATUS reply length
Date: Mon, 13 May 2019 14:47:06 +0000

13.05.2019 17:31, Eric Blake wrote:
> On 5/13/19 5:03 AM, Vladimir Sementsov-Ogievskiy wrote:
>> 10.05.2019 18:17, Eric Blake wrote:
>>> Commit 3d068aff (3.0) introduced NBD_MAX_BITMAP_EXTENTS as a limit on
>>> how large we would allow a reply to NBD_CMD_BLOCK_STATUS to grow when
>>> it is visiting a qemu:dirty-bitmap: context.  Later, commit fb7afc79
>>> (3.1) reused the constant to limit base:allocation context replies,
>>> although the name is now less appropriate in that situation.
>>> Rename things, and improve the macro to use units.h for better
>>> legibility. Then reformat the comment to comply with checkpatch rules
>>> added in the meantime. No semantic change.
>>> Signed-off-by: Eric Blake <address@hidden>
>> With or without Stefano's suggestion:
>> Signed-off-by: Vladimir Sementsov-Ogievskiy <address@hidden>
> I'm assuming Reviewed-by instead of Signed-off-by?

Aha, of course. Copy-pasted and forget to fix(

Best regards,

reply via email to

[Prev in Thread] Current Thread [Next in Thread]