[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-block] [PATCH v7 5/5] block/backup: refactor: split out backup

From: Max Reitz
Subject: Re: [Qemu-block] [PATCH v7 5/5] block/backup: refactor: split out backup_calculate_cluster_size
Date: Thu, 9 May 2019 18:12:39 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1

On 29.04.19 11:08, Vladimir Sementsov-Ogievskiy wrote:
> Split out cluster_size calculation. Move copy-bitmap creation above
> block-job creation, as we are going to share it with upcoming
> backup-top filter, which also should be created before actual block job
> creation.
> Also, while being here, drop unnecessary "goto error" from
> bdrv_getlength error path.

This paragraph should be dropped now.  Do you mind me doing it?


> Signed-off-by: Vladimir Sementsov-Ogievskiy <address@hidden>
> ---
>  block/backup.c | 82 ++++++++++++++++++++++++++++++++------------------
>  1 file changed, 52 insertions(+), 30 deletions(-)

Attachment: signature.asc
Description: OpenPGP digital signature

reply via email to

[Prev in Thread] Current Thread [Next in Thread]