qemu-block
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-block] [PATCH v2 1/5] qemu-nbd: Add --pid-file option


From: Max Reitz
Subject: Re: [Qemu-block] [PATCH v2 1/5] qemu-nbd: Add --pid-file option
Date: Wed, 8 May 2019 22:45:16 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1

On 08.05.19 15:22, Max Reitz wrote:
> --fork is a bit boring if there is no way to get the child's PID.  This
> option helps.
> 
> Signed-off-by: Max Reitz <address@hidden>
> ---
>  qemu-nbd.c    | 12 ++++++++++++
>  qemu-nbd.texi |  2 ++
>  2 files changed, 14 insertions(+)
> 
> diff --git a/qemu-nbd.c b/qemu-nbd.c
> index dca9e72cee..4866042160 100644
> --- a/qemu-nbd.c
> +++ b/qemu-nbd.c

[...]

> @@ -677,6 +680,8 @@ int main(int argc, char **argv)
>      bool list = false;
>      int old_stderr = -1;
>      unsigned socket_activation;
> +    const char *pid_file_name = NULL;
> +    FILE *pid_file;

Great to see how well I test my patches.  This shouldn’t be here
anymore, of course.

Max

Attachment: signature.asc
Description: OpenPGP digital signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]