[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [Qemu-devel] [RFC PATCH] tests/qemu-iotests: re-format
Re: [Qemu-block] [Qemu-devel] [RFC PATCH] tests/qemu-iotests: re-format output to for make check-block
Mon, 6 May 2019 12:32:19 -0500
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1
On 5/5/19 10:54 AM, Thomas Huth wrote:
>>> That's why I thought that having a TAP mode for the check script could
>>> be a good idea, too. Then we could pipe the output through the
>>> tap-driver.pl script, too, so we get uniform output for all tests...?
>> That would probably be a cleaner approach. What would be even better is
>> somehow expanding the list of tests at make time so you could run your
>> tests in parallel.
> I agree that this might be the ultimate solution ... but I'm not sure
> whether the iotests are really ready for being run in parallel yet,
No, they are not. Jeff Cody had a patch series that converted
qemu-iotests/check to run every test in its own subdirectory instead of
in a shared spot, which we would have to revive first.
>> I did wonder how useful the timing stuff was to developers.
> Yes, me too ... maybe the block layer folks can comment on that one...?
I like it; it gives me an idea of how long a test is expected to run
(some are definitely longer than others), and whether the 'quick' tag is
appropriate. But I will not necessarily be heartbroken if you can't
preserve it while making the test output easier to consume by other tooling.
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
Description: OpenPGP digital signature
Re: [Qemu-block] [RFC PATCH] tests/qemu-iotests: re-format output to for make check-block, Thomas Huth, 2019/05/05
Re: [Qemu-block] [RFC PATCH] tests/qemu-iotests: re-format output to for make check-block, Kevin Wolf, 2019/05/07