Re: [Qemu-block] [Qemu-devel] [PATCH for-QEMU-4.1 v5 07/29] hw/arm: Express dependencies of the fsl-imx31 machine with Kconfig

[Philippe Mathieu-Daudé]

On 4/18/19 8:00 PM, Thomas Huth wrote:
> Add Kconfig dependencies for the fsl-imx31 / kzm machine.
> This patch is slightly based on earlier work by Ákos Kovács (i.e.
> his "hw/arm/Kconfig: Add ARM Kconfig" patch).
> 
> Signed-off-by: Thomas Huth <address@hidden>
> ---
>  default-configs/arm-softmmu.mak | 3 +--
>  hw/arm/Kconfig                  | 4 ++++
>  hw/misc/Kconfig                 | 2 ++
>  3 files changed, 7 insertions(+), 2 deletions(-)
> 
> diff --git a/default-configs/arm-softmmu.mak b/default-configs/arm-softmmu.mak
> index 6195b75f48..7f94811ccb 100644
> --- a/default-configs/arm-softmmu.mak
> +++ b/default-configs/arm-softmmu.mak
> @@ -10,6 +10,7 @@ CONFIG_PCI_TESTDEV=y
>  CONFIG_EXYNOS4=y
>  CONFIG_HIGHBANK=y
>  CONFIG_INTEGRATOR=y
> +CONFIG_FSL_IMX31=y
>  
>  CONFIG_VGA=y
>  CONFIG_NAND=y
> @@ -68,7 +69,6 @@ CONFIG_TSC210X=y
>  CONFIG_BLIZZARD=y
>  CONFIG_ONENAND=y
>  CONFIG_TUSB6010=y
> -CONFIG_IMX=y
>  CONFIG_MAINSTONE=y
>  CONFIG_MPS2=y
>  CONFIG_MUSCA=y
> @@ -115,7 +115,6 @@ CONFIG_ALLWINNER_A10_PIC=y
>  CONFIG_ALLWINNER_A10=y
>  
>  CONFIG_FSL_IMX6=y
> -CONFIG_FSL_IMX31=y
>  CONFIG_FSL_IMX25=y
>  CONFIG_FSL_IMX7=y
>  CONFIG_FSL_IMX6UL=y
> diff --git a/hw/arm/Kconfig b/hw/arm/Kconfig
> index ad3b1f9b40..9087b7d714 100644
> --- a/hw/arm/Kconfig
> +++ b/hw/arm/Kconfig
> @@ -98,6 +98,10 @@ config FSL_IMX25
>  
>  config FSL_IMX31
>      bool
> +    select SERIAL
> +    select IMX
> +    select IMX_I2C
> +    select LAN9118

Similarly to my comment on patch 6 of this series:
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>

>  
>  config FSL_IMX6
>      bool
> diff --git a/hw/misc/Kconfig b/hw/misc/Kconfig
> index 5f67d0d6d9..385e1b0cec 100644
> --- a/hw/misc/Kconfig
> +++ b/hw/misc/Kconfig
> @@ -76,6 +76,8 @@ config ECCMEMCTL
>  config IMX
>      bool
>      select PTIMER
> +    select SSI
> +    select USB_EHCI_SYSBUS
>  
>  config STM32F2XX_SYSCFG
>      bool
>