[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [Qemu-devel] [PATCH 01/10] block/pflash_cfi02: Add test
From: |
Stephen Checkoway |
Subject: |
Re: [Qemu-block] [Qemu-devel] [PATCH 01/10] block/pflash_cfi02: Add test for supported commands |
Date: |
Tue, 9 Apr 2019 11:37:10 -0400 |
On Apr 9, 2019, at 02:13, Thomas Huth <address@hidden> wrote:
> We'd like to get rid of global_qtest in the long run (since it is
> causing trouble for tests that run multiple instances of QEMU in
> parallel, e.g. migration tests)... so if it is feasible, please don't
> use it in new code anymore. Try to use a local variable in the function
> that call qtest_initf() and pass the test state around via a parameter
> to the functions that need it.
One of the patches introduces a FlashConfig structure which gets passed around
to all the functions. I could stuff the local qtest in there. The earlier
patches would still use global_qtest. Would that be acceptable or would you
prefer that global_qtest not appear in any of the patches?
Or rather than putting it in the FlashConfig struct, I could just pass a
separate parameter around. Whatever you prefer.
--
Stephen Checkoway
- [Qemu-block] [PATCH 00/10] block/pflash_cfi02: Implement missing AMD pflash functionality, Stephen Checkoway, 2019/04/08
- [Qemu-block] [PATCH 01/10] block/pflash_cfi02: Add test for supported commands, Stephen Checkoway, 2019/04/08
- Re: [Qemu-block] [Qemu-devel] [PATCH 01/10] block/pflash_cfi02: Add test for supported commands, Thomas Huth, 2019/04/09
- Re: [Qemu-block] [Qemu-devel] [PATCH 01/10] block/pflash_cfi02: Add test for supported commands, Markus Armbruster, 2019/04/09
- Re: [Qemu-block] [Qemu-devel] [PATCH 01/10] block/pflash_cfi02: Add test for supported commands, Thomas Huth, 2019/04/09
- Re: [Qemu-block] [Qemu-devel] [PATCH 01/10] block/pflash_cfi02: Add test for supported commands, Markus Armbruster, 2019/04/09
- Re: [Qemu-block] [Qemu-devel] [PATCH 01/10] block/pflash_cfi02: Add test for supported commands, Thomas Huth, 2019/04/09
- Re: [Qemu-block] [Qemu-devel] [PATCH 01/10] block/pflash_cfi02: Add test for supported commands, Markus Armbruster, 2019/04/09
- Re: [Qemu-block] [Qemu-devel] [PATCH 01/10] block/pflash_cfi02: Add test for supported commands,
Stephen Checkoway <=
- Re: [Qemu-block] [Qemu-devel] [PATCH 01/10] block/pflash_cfi02: Add test for supported commands, Thomas Huth, 2019/04/10
[Qemu-block] [PATCH 02/10] block/pflash_cfi02: Refactor, NFC intended, Stephen Checkoway, 2019/04/08
[Qemu-block] [PATCH 03/10] block/pflash_cfi02: Fix command address comparison, Stephen Checkoway, 2019/04/08
[Qemu-block] [PATCH 07/10] block/pflash_cfi02: Fix reset command not ignored during erase, Stephen Checkoway, 2019/04/08
[Qemu-block] [PATCH 06/10] block/pflash_cfi02: Fix CFI in autoselect mode, Stephen Checkoway, 2019/04/08
[Qemu-block] [PATCH 04/10] block/pflash_cfi02: Implement intereleaved flash devices, Stephen Checkoway, 2019/04/08
[Qemu-block] [PATCH 05/10] block/pflash_cfi02: Implement nonuniform sector sizes, Stephen Checkoway, 2019/04/08
[Qemu-block] [PATCH 08/10] block/pflash_cfi02: Implement multi-sector erase, Stephen Checkoway, 2019/04/08
[Qemu-block] [PATCH 10/10] block/pflash_cfi02: Use the chip erase time specified in the CFI table, Stephen Checkoway, 2019/04/08
[Qemu-block] [PATCH 09/10] block/pflash_cfi02: Implement erase suspend/resume, Stephen Checkoway, 2019/04/08