[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH v2] block/file-posix: ignore fail on unlock byte
From: |
Eric Blake |
Subject: |
Re: [Qemu-block] [PATCH v2] block/file-posix: ignore fail on unlock bytes |
Date: |
Thu, 28 Mar 2019 13:24:22 -0500 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.0 |
On 3/28/19 2:21 AM, Vladimir Sementsov-Ogievskiy wrote:
> bdrv_replace_child() calls bdrv_check_perm() with error_abort on
> loosening permissions. However file-locking operations may fail even
> in this case, for example on NFS. And this leads to Qemu crash.
>
> Let's ignore such errors, as we do already on permission update commit
> and abort.
>
> Signed-off-by: Vladimir Sementsov-Ogievskiy <address@hidden>
> ---
>
> v2: - simplify expression [Eric]
> - fix bug s/new_perm/new_shared
>
> block/file-posix.c | 14 ++++++++++++++
> 1 file changed, 14 insertions(+)
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-block] [PATCH v2] block/file-posix: ignore fail on unlock bytes, Vladimir Sementsov-Ogievskiy, 2019/03/28
- Re: [Qemu-block] [PATCH v2] block/file-posix: ignore fail on unlock bytes,
Eric Blake <=
- Re: [Qemu-block] [PATCH v2] block/file-posix: ignore fail on unlock bytes, Kevin Wolf, 2019/03/28
- Re: [Qemu-block] [PATCH v2] block/file-posix: ignore fail on unlock bytes, Vladimir Sementsov-Ogievskiy, 2019/03/29
- Re: [Qemu-block] [PATCH v2] block/file-posix: ignore fail on unlock bytes, Kevin Wolf, 2019/03/29
- Re: [Qemu-block] [PATCH v2] block/file-posix: ignore fail on unlock bytes, Vladimir Sementsov-Ogievskiy, 2019/03/29
- Re: [Qemu-block] [PATCH v2] block/file-posix: ignore fail on unlock bytes, Vladimir Sementsov-Ogievskiy, 2019/03/29
- Re: [Qemu-block] [PATCH v2] block/file-posix: ignore fail on unlock bytes, Kevin Wolf, 2019/03/29
- Re: [Qemu-block] [PATCH v2] block/file-posix: ignore fail on unlock bytes, Vladimir Sementsov-Ogievskiy, 2019/03/29
- Re: [Qemu-block] [PATCH v2] block/file-posix: ignore fail on unlock bytes, Vladimir Sementsov-Ogievskiy, 2019/03/29