[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH v3 01/12] block: Mark commit and mirror as filte
Re: [Qemu-block] [PATCH v3 01/12] block: Mark commit and mirror as filter drivers
Tue, 19 Mar 2019 14:16:00 +0100
Am 13.02.2019 um 23:53 hat Max Reitz geschrieben:
> The commit and mirror block nodes are filters, so they should be marked
> as such.
> Signed-off-by: Max Reitz <address@hidden>
> Reviewed-by: Alberto Garcia <address@hidden>
Then we need to update the definition of a filter:
/* set to true if the BlockDriver is a block filter. Block filters pass
* certain callbacks that refer to data (see block.c) to their bs->file if
* the driver doesn't implement them. Drivers that do not wish to forward
* must implement them and return -ENOTSUP.
This talks about bs->file specifically, and commit and mirror nodes use
bs->backing instead. Most places that check bs->in_filter do so to check
whether they can forward stuff to bs->file, and they don't consider
I think the latter will be fixed after patch 3, but the definition in
the comment is still wrong at the end of the series.
|[Prev in Thread]
||[Next in Thread]|
- Re: [Qemu-block] [PATCH v3 01/12] block: Mark commit and mirror as filter drivers,
Kevin Wolf <=