Re: [Qemu-block] [PATCH v2 09/13] block: Add a 'mutable_opts' field to BlockDriver

[Kevin Wolf]

Am 12.03.2019 um 13:32 hat Kevin Wolf geschrieben:
> Am 06.03.2019 um 19:11 hat Alberto Garcia geschrieben:
> > If we reopen a BlockDriverState and there is an option that is present
> > in bs->options but missing from the new set of options then we have to
> > return an error unless the driver is able to reset it to its default
> > value.
> > 
> > This patch adds a new 'mutable_opts' field to BlockDriver. This is
> > a list of runtime options that can be modified during reopen. If an
> > option in this list is unspecified on reopen then it must be reset (or
> > return an error).
> > 
> > Signed-off-by: Alberto Garcia <address@hidden>
> > ---
> >  block/file-posix.c        |  6 ++++++
> >  block/qcow2.c             | 25 +++++++++++++++++++++++++
> >  block/raw-format.c        |  3 +++
> >  include/block/block_int.h |  8 ++++++++
> >  4 files changed, 42 insertions(+)
> 
> Two more drivers seem to be able to change options: gluster (debug and
> logfile) and throttle (throttle-group).

Actually those aren't necessary in this patch: throttle-group isn't even
optional, so it never has to be reset; and I misread the gluster code,
it just re-adds the old values for debug and logfile and doesn't
actually accept changes.

So the patch looks fine, after all.

Kevin