[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-block] [PATCH v3 5/7] block/dirty-bitmaps: prohibit removing reado
From: |
John Snow |
Subject: |
[Qemu-block] [PATCH v3 5/7] block/dirty-bitmaps: prohibit removing readonly bitmaps |
Date: |
Fri, 1 Mar 2019 14:15:43 -0500 |
Remove is an inherently RW operation, so this will fail anyway, but
we can fail it very quickly instead of trying and failing, so do so.
Signed-off-by: John Snow <address@hidden>
---
blockdev.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/blockdev.c b/blockdev.c
index c8255dda0b..a9a059c570 100644
--- a/blockdev.c
+++ b/blockdev.c
@@ -2881,7 +2881,8 @@ void qmp_block_dirty_bitmap_remove(const char *node,
const char *name,
return;
}
- if (bdrv_dirty_bitmap_check(bitmap, BDRV_BITMAP_BUSY, errp)) {
+ if (bdrv_dirty_bitmap_check(bitmap, BDRV_BITMAP_BUSY | BDRV_BITMAP_RO,
+ errp)) {
return;
}
--
2.17.2
- Re: [Qemu-block] [PATCH v3 1/7] block/dirty-bitmaps: add inconsistent bit, (continued)
[Qemu-block] [PATCH v3 2/7] block/dirty-bitmap: add inconsistent status, John Snow, 2019/03/01
[Qemu-block] [PATCH v3 4/7] block/dirty-bitmaps: prohibit readonly bitmaps for backups, John Snow, 2019/03/01
[Qemu-block] [PATCH v3 5/7] block/dirty-bitmaps: prohibit removing readonly bitmaps,
John Snow <=
[Qemu-block] [PATCH v3 3/7] block/dirty-bitmaps: add block_dirty_bitmap_check function, John Snow, 2019/03/01
Re: [Qemu-block] [PATCH v3 3/7] block/dirty-bitmaps: add block_dirty_bitmap_check function, Vladimir Sementsov-Ogievskiy, 2019/03/06
[Qemu-block] [PATCH v3 6/7] block/dirty-bitmaps: disallow busy bitmaps as merge source, John Snow, 2019/03/01