[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH 09/13] block: Add 'runtime_opts' and 'mutable_op
|
From: |
Alberto Garcia |
|
Subject: |
Re: [Qemu-block] [PATCH 09/13] block: Add 'runtime_opts' and 'mutable_opts' fields to BlockDriver |
|
Date: |
Fri, 01 Mar 2019 15:37:31 +0100 |
|
User-agent: |
Notmuch/0.18.2 (http://notmuchmail.org) Emacs/24.4.1 (i586-pc-linux-gnu) |
On Fri 01 Mar 2019 03:18:09 PM CET, Kevin Wolf wrote:
> Hm, actually, do you even need the runtime_opts list?
>
> You use it in bdrv_reset_options_allowed() to iterate through each
> option and then check whether it was present in the old set of
> options, but not in the new set of options.
>
> In order to achieve this, you can just iterate the old options dict
> because you don't do anything with options that are present in the
> QemuOptsList, but not the old options dict.
Hmm, that could work, I'll give it a try.
Berto