Re: [Qemu-block] [Qemu-devel] [PATCH 00/10] pflash: Fixes and cleanups

[no-reply]

Patchew URL: https://patchew.org/QEMU/address@hidden/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Message-id: address@hidden
Subject: [Qemu-devel] [PATCH 00/10] pflash: Fixes and cleanups
Type: series

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Switched to a new branch 'test'
03f9a76b8c hw/arm hw/xtensa: De-duplicate pflash creation code some
4e432c01fe pflash: Clean up after commit 368a354f02b part 2
bd61cf81c3 pflash: Clean up after commit 368a354f02b part 1
31e9871f71 mips_malta: Clean up definition of flash memory size somewhat
66c8ac0932 r2d: Flash memory creation is confused about size, mark FIXME
857cd68a50 ppc405_boards: Don't size flash memory to match backing image
170a8ce912 sam460ex: Don't size flash memory to match backing image
aa2df2f4fd hw: Use CFI_PFLASH0{1, 2} and TYPE_CFI_PFLASH0{1, 2}
588d5b718c pflash: Macro PFLASH_BUG() is used just once, expand
f4339a63b6 pflash: Rename pflash_t to PFlashCFI01, PFlashCFI02

=== OUTPUT BEGIN ===
1/10 Checking commit f4339a63b6dd (pflash: Rename pflash_t to PFlashCFI01, 
PFlashCFI02)
ERROR: space prohibited between function name and open parenthesis '('
#127: FILE: hw/block/pflash_cfi01.c:288:
+static uint32_t pflash_read (PFlashCFI01 *pfl, hwaddr offset,

ERROR: space prohibited between function name and open parenthesis '('
#339: FILE: hw/block/pflash_cfi02.c:141:
+static uint32_t pflash_read (PFlashCFI02 *pfl, hwaddr offset,

ERROR: space prohibited between function name and open parenthesis '('
#357: FILE: hw/block/pflash_cfi02.c:264:
+static void pflash_write (PFlashCFI02 *pfl, hwaddr offset,

total: 3 errors, 0 warnings, 483 lines checked

Patch 1/10 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

2/10 Checking commit 588d5b718cc4 (pflash: Macro PFLASH_BUG() is used just 
once, expand)
3/10 Checking commit aa2df2f4fd70 (hw: Use CFI_PFLASH0{1, 2} and 
TYPE_CFI_PFLASH0{1, 2})
4/10 Checking commit 170a8ce912fd (sam460ex: Don't size flash memory to match 
backing image)
5/10 Checking commit 857cd68a500d (ppc405_boards: Don't size flash memory to 
match backing image)
6/10 Checking commit 66c8ac09327b (r2d: Flash memory creation is confused about 
size, mark FIXME)
7/10 Checking commit 31e9871f7159 (mips_malta: Clean up definition of flash 
memory size somewhat)
8/10 Checking commit bd61cf81c38f (pflash: Clean up after commit 368a354f02b 
part 1)
ERROR: spaces required around that '-' (ctx:VxV)
#89: FILE: hw/arm/musicpal.c:1639:
+        pflash_cfi02_register(0x100000000ULL-MP_FLASH_SIZE_MAX,
                                             ^

ERROR: spaces required around that '-' (ctx:VxV)
#97: FILE: hw/arm/musicpal.c:1646:
+        pflash_cfi02_register(0x100000000ULL-MP_FLASH_SIZE_MAX,
                                             ^

total: 2 errors, 0 warnings, 248 lines checked

Patch 8/10 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

9/10 Checking commit 4e432c01fea3 (pflash: Clean up after commit 368a354f02b 
part 2)
10/10 Checking commit 03f9a76b8cbd (hw/arm hw/xtensa: De-duplicate pflash 
creation code some)
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/address@hidden/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to address@hidden