[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH v3 3/8] tests: Add QAPI optional discriminator t
From: |
Eric Blake |
Subject: |
Re: [Qemu-block] [PATCH v3 3/8] tests: Add QAPI optional discriminator tests |
Date: |
Wed, 6 Feb 2019 14:20:11 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.4.0 |
On 2/6/19 1:55 PM, Max Reitz wrote:
> There already is an optional discriminator test, although it also noted
> the discriminator name itself as optional. This already gives us one
> error test case, to which this patch adds various others.
>
> Furthermore, a passing test case is added to qapi-schema-test.
>
> Signed-off-by: Max Reitz <address@hidden>
> ---
Reviewed-by: Eric Blake <address@hidden>
This could also be squashed with patch 1 to avoid a window of 'make
check' breakage during a bisect; but as that makes the overall changes
bigger to review, leaving them separate is not too terrible.
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-block] [PATCH v3 0/8] block: Try to create well-typed json:{} filenames, Max Reitz, 2019/02/06
- [Qemu-block] [PATCH v3 2/8] docs/qapi: Document optional discriminators, Max Reitz, 2019/02/06
- [Qemu-block] [PATCH v3 3/8] tests: Add QAPI optional discriminator tests, Max Reitz, 2019/02/06
- Re: [Qemu-block] [PATCH v3 3/8] tests: Add QAPI optional discriminator tests,
Eric Blake <=
- [Qemu-block] [PATCH v3 4/8] qapi: Formalize qcow2 encryption probing, Max Reitz, 2019/02/06
- [Qemu-block] [PATCH v3 5/8] qapi: Formalize qcow encryption probing, Max Reitz, 2019/02/06
- [Qemu-block] [PATCH v3 6/8] block: Try to create well typed json:{} filenames, Max Reitz, 2019/02/06
- [Qemu-block] [PATCH v3 7/8] iotests: Test internal option typing, Max Reitz, 2019/02/06
- [Qemu-block] [PATCH v3 8/8] iotests: qcow2's encrypt.format is now optional, Max Reitz, 2019/02/06