[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH v2 3/5] virtio-blk: add DISCARD and WRITE ZEROES
|
From: |
Stefan Hajnoczi |
|
Subject: |
Re: [Qemu-block] [PATCH v2 3/5] virtio-blk: add DISCARD and WRITE ZEROES features |
|
Date: |
Fri, 1 Feb 2019 18:08:47 +0800 |
|
User-agent: |
Mutt/1.10.1 (2018-07-13) |
On Fri, Feb 01, 2019 at 10:54:30AM +0100, Stefano Garzarella wrote:
> On Fri, Feb 01, 2019 at 12:58:31PM +0800, Stefan Hajnoczi wrote:
> > On Thu, Jan 31, 2019 at 04:19:12PM +0100, Stefano Garzarella wrote:
> Only a question about options: I used a single option "dwz_max_sectors"
> for both "max_discard_sectors" and "max_write_zeroes_sectors".
> Since I'll include two options to enable/disable discard and
> write_zeroes features, do you think make sense to split this
> configurable option in two?
Yes, please. Eventually a user will want full control so it makes sense
to expose what virtio offers instead of coming up with higher-level
options.
Stefan
signature.asc
Description: PGP signature