[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-block] [Qemu-devel] [PATCH 3/9] iotests: Fix 232 for LUKS

From: Max Reitz
Subject: Re: [Qemu-block] [Qemu-devel] [PATCH 3/9] iotests: Fix 232 for LUKS
Date: Wed, 30 Jan 2019 14:05:13 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.4.0

On 29.01.19 22:26, John Snow wrote:
> On 1/23/19 9:46 AM, Max Reitz wrote:
>> With IMGOPTSSYNTAX, $TEST_IMG is useless for this test (it only tests
>> the file-posix protocol driver).  Therefore, if $TEST_IMG_FILE is set,
>> use that instead.
>> Because this test requires the file protocol, $TEST_IMG_FILE will always
>> be set if $IMGOPTSSYNTAX is true.
>> Signed-off-by: Max Reitz <address@hidden>
> This keeps biting us. Or at least, it bit me once and then it has bitten
> someone else. It's not obvious that you need to accommodate this when
> writing a new test.

No, it isn't. :-)

But I think at least me running ./check -luks from time to time should
be sufficient, usually.  It's just that I had basically given up on a
clean iotests run for a month or two now...


Attachment: signature.asc
Description: OpenPGP digital signature

reply via email to

[Prev in Thread] Current Thread [Next in Thread]