[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-block] [PATCH v8 2/2] qemu-img info: bitmaps extension new tes

From: Eric Blake
Subject: Re: [Qemu-block] [PATCH v8 2/2] qemu-img info: bitmaps extension new test 239
Date: Mon, 28 Jan 2019 13:11:55 -0600
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.4.0

On 1/28/19 12:40 PM, Andrey Shinkevich wrote:
> A new test file 239 added to the qemu-iotests set. It checks
> the output format of 'qemu-img info' for bitmaps extension of
> qcow2 specific information.
> Signed-off-by: Andrey Shinkevich <address@hidden>
> ---

> +++ b/tests/qemu-iotests/239.out
> @@ -0,0 +1,33 @@
> +{"execute": "block-dirty-bitmap-add", "arguments": {"granularity": 16384, 
> "name": "bitmap-1", "node": "drive0", "persistent": true}}
> +{"return": {}}
> +{"execute": "block-dirty-bitmap-add", "arguments": {"granularity": 32768, 
> "name": "bitmap-2", "node": "drive0", "persistent": true}}
> +{"return": {}}
> +{"execute": "block-dirty-bitmap-add", "arguments": {"granularity": 65536, 
> "name": "bitmap-3", "node": "drive0", "persistent": true}}

Should the test also create a disabled bitmap ("enabled":false), to show
the change in flags, and/or a non-persistent bitmap (to show that it
does not affect the qcow2 information, but only the query-blocks output,
because it is transient)?

Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature

reply via email to

[Prev in Thread] Current Thread [Next in Thread]