[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-block] [PATCH 3/3] iotests: Allow 147 to be run concurrently

From: Max Reitz
Subject: Re: [Qemu-block] [PATCH 3/3] iotests: Allow 147 to be run concurrently
Date: Fri, 25 Jan 2019 16:01:26 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.4.0

On 23.01.19 18:47, John Snow wrote:
> On 1/23/19 12:34 PM, Max Reitz wrote:
>> On 23.01.19 14:05, Max Reitz wrote:
>>> On 21.01.19 21:50, John Snow wrote:
>> [...]
>>>> I guess my only other observation is that we have a lot of "while True"
>>>> loops now, is it worth creating some kind of helper that does the dirty
>>>> work of finding a serviceable port or nah?
>>> Seems reasonable, I'll see how it looks.
>> If I do that, the diff stat looks to be 40+, 33-.  Is that worth it?
>> Max
> Instead of:
>  1 file changed, 68 insertions(+), 30 deletions(-)
> Or in addition to?

In addition to.

> Use your own judg[e?]ment on it, I guess it's local to this one iotest
> for now anyway, so if it's not an obvious win just skip it.

OK.  I guess I'll skip it then, but let it be noted that your criticism
was listened to. :-)


Attachment: signature.asc
Description: OpenPGP digital signature

reply via email to

[Prev in Thread] Current Thread [Next in Thread]