[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-block] [PATCH 0/3] block: fix last address-of-packed-member wa

From: Kevin Wolf
Subject: Re: [Qemu-block] [PATCH 0/3] block: fix last address-of-packed-member warnings
Date: Fri, 18 Jan 2019 17:17:46 +0100
User-agent: Mutt/1.10.1 (2018-07-13)

Am 10.12.2018 um 12:26 hat Peter Maydell geschrieben:
> This patchset fixes the remaining clang warnings in the block/ code
> about taking the address of a packed struct member, which are all
> in block/vpc and block/vdi code handling UUIDs. Mostly I fix
> these by copying the unaligned field to/from a local variable.
> In the case of qemu_uuid_bswap() I opted to change the API to
> take and return the QemuUUID rather than taking a pointer to it,
> which makes almost all the callsites simpler. This does mean
> a struct copy but the struct is only 16 bytes and I didn't
> judge any of the callsites performance-sensitive enough to care
> about a struct copy of that size.
> As usual, tested with "make check" only.

Thanks, applied to the block branch.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]