|
| From: | Alberto Garcia |
| Subject: | Re: [Qemu-block] [PATCH v12 09/10] qcow2: skip writing zero buffers to empty COW areas |
| Date: | Wed, 16 Jan 2019 10:35:38 +0100 |
| User-agent: | Notmuch/0.18.2 (http://notmuchmail.org) Emacs/24.4.1 (i586-pc-linux-gnu) |
On Wed 16 Jan 2019 10:32:33 AM CET, Anton Nefedov wrote:
>>> + ret = handle_alloc_space(bs, l2meta);
>>
>> I insist that it would be nice to have a short comment explaining
>> what this does.
>
> Right sorry forgot your comment.
> I'd go with:
>
> + /* Try to efficiently initialize the physical space with zeroes */
> ret = handle_alloc_space(bs, l2meta);
> if (ret < 0) {
> qemu_co_mutex_lock(&s->lock);
That looks good, thanks!
Berto
| [Prev in Thread] | Current Thread | [Next in Thread] |