[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-block] [Qemu-devel] [PATCH 1/1] include: Auto-generate the siz

From: Eric Blake
Subject: Re: [Qemu-block] [Qemu-devel] [PATCH 1/1] include: Auto-generate the sizes lookup table
Date: Thu, 3 Jan 2019 15:04:25 -0600
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.3.1

On 1/3/19 2:57 PM, Leonid Bloch wrote:

>> I have to say that I'm not very convinced of the benefits of replacing a
>> set of trivial numeric macros with a longer and harder to read shell
>> script accompanied by changes to the build system.
> I think that the benefit is that the script is easily verifiable, 
> whereas if someone would like to verify the table, they will need to 
> generate it themselves. Also, this table is automatically generated 
> anyway, so it only makes sense to generate it during the build.

But no one is submitting patches to active modify the table.  The work
has already been done once to generate it, and the reviewers have
already verified it; at this point, no further changes are likely to
happen (other than my pipe dream of entirely getting rid of the table in
favor of using runtime generation of human-friendly default strings is
added to QemuOpts instead).  If the table were not already in git, then
generating it at build time might make sense; but at this stage in the
game, you're slowing down every build to regenerate something that is
already correct.

Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature

reply via email to

[Prev in Thread] Current Thread [Next in Thread]